Hi Tom, On 7 March 2016 at 16:37, Tom Rini <tr...@konsulko.com> wrote: > On Sun, Mar 06, 2016 at 07:38:47PM -0700, Simon Glass wrote: >> Hi Stephen, >> >> On 5 March 2016 at 23:26, Stephen Warren <swar...@wwwdotorg.org> wrote: >> > >> > On 02/05/2016 09:19 PM, Stephen Warren wrote: >> >> >> >> On 02/05/2016 02:43 PM, Eric Anholt wrote: >> >>> >> >>> For Raspberry Pi, we had the input clock rate to the pl011 fixed in >> >>> the rpi.c file, but it may be changed by firmware due to user changes >> >>> to config.txt. Since the firmware always sets up the uart (default >> >>> 115200 output unless the user changes it), we can just skip our own >> >>> uart init to simplify the boot process and more reliably get serial >> >>> output. >> >> >> >> >> >> Tested-by: Stephen Warren <swar...@wwwdotorg.org> >> >> (With a 6MHz init_uart_clock and with/without init_uart_baud=9600) >> > >> > >> > Simon/Tom, did this slip through the cracks, or are you deferring it until >> > the next release? >> >> We haven't heard back on the review comments. >> >> I don't really mind if we go the DT approach or this one. But this >> patch needs a little rework I think. > > I thought the main review comment was "didn't we try and do this with > DT?" ? I'm feeling like we might want to skip doing anything DT related > for this part...
My comment was on 6 Feb: > + TYPE_PL01X_PRECONFIGURED, This seems odd. You are not adding a new UART type. How about a separate bool flag? Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
