Hi Marek, On 27 November 2015 at 11:41, Marek Vasut <ma...@denx.de> wrote: > On Friday, November 27, 2015 at 07:36:27 PM, Simon Glass wrote: >> Hi, >> >> On 26 November 2015 at 23:22, Chin Liang See <cl...@altera.com> wrote: >> > Enable SDMMC calibration to determine the best setting for >> > drvsel and smplsel. Calibration will be triggered if the >> > drvsel and smplsel node are not available in DTS. >> > >> > Signed-off-by: Chin Liang See <cl...@altera.com> >> > Cc: Dinh Nguyen <dingu...@opensource.altera.com> >> > Cc: Dinh Nguyen <dinh.li...@gmail.com> >> > Cc: Pavel Machek <pa...@denx.de> >> > Cc: Marek Vasut <ma...@denx.de> >> > Cc: Stefan Roese <s...@denx.de> >> > Cc: Pantelis Antoniou <pantelis.anton...@konsulko.com> >> > Cc: Simon Glass <s...@chromium.org> >> > Cc: Jaehoon Chung <jh80.ch...@samsung.com> >> > --- >> > Changes for v4 >> > - Calibration only run if node not in DTS >> > Changes for v3 >> > - Remove the && ok as its redundant >> > Changes for v2 >> > - Using standard error return macro >> > - Split to small function to avoid deep identation >> > - Fix coding standard >> > --- >> > >> > drivers/mmc/socfpga_dw_mmc.c | 208 >> > ++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 205 >> > insertions(+), 3 deletions(-) >> >> Should this code go in the generic dw_mmc.c file instead? > > *Marek grabs popcorn* > > You might want to read the discussion(s) below the previous versions of the > patch, but TLDR, samsung doesn't want the calibration code to interfere with > their driver it seems.
OK, fair enough. Let's see what happens when the next person wants to add this feature. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
