Dear Vikas, In message <1443053976-9112-4-git-send-email-vikas.mano...@st.com> you wrote: > > --- a/drivers/spi/cadence_qspi.c > +++ b/drivers/spi/cadence_qspi.c > @@ -290,6 +290,8 @@ static int cadence_spi_ofdata_to_platdata(struct udevice > *bus) > > plat->regbase = (void *)data[0]; > plat->ahbbase = (void *)data[2]; > + plat->trigger_base = (u32 *)fdtdec_get_addr(blob, node, > + "cdns,trigger-address");
What happens if fdtdec_get_addr() returns FDT_ADDR_T_NONE? I think we should implement some error handling here. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "The whole world is about three drinks behind." - Humphrey Bogart _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
