Jean-Christophe PLAGNIOL-VILLARD wrote: > On 16:02 Wed 08 Jul , Matthias Weisser wrote: >> This patch adds support for the display controller in >> the MB86R01 'Jade' SoC. >> >> Signed-off-by: Matthias Weisser <matthias.weis...@graf-syteco.de> >> --- ... >> + >> +/* >> + * 4MB (at the end of system RAM) >> + */ >> +#define VIDEO_MEM_SIZE 0x400000 >> + >> +#define GDC_HOST_BASE 0xF1FC0000 >> +#define GDC_DSP0_BASE 0xF1FD0000 >> +#define GDC_DSP1_BASE 0xF1FD2000 > please move to a header
probably we should drop these entirely and use JADE_GDC_PHYS_BASE and JADE_GDC_PHYS_DISP_BASE from include/asm-arm/arch-jade/jade.h file introduced with this patch series? Just need to add the base for second display controller register block there. ... >> +GraphicDevice jadegdc; > please no uppercase in type we have to stay with GraphicDevice type in this patch now. It is there in U-Boot code since more than five years, Matthias simply uses it here as other video drivers use it, too. But yes, we should do general video code cleanup later. Best regards, Anatolij _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
