On Tue, May 26, 2009 at 01:48:08AM -0700, Prafulla Wadaskar wrote: > Good Feedback... > The name board_nand_init() is confusing here.... Why the board specific code > is in drivers/mtd/nand/? > Whereas I can see more references in board/* > But looking other code references in this folder your feedback stands valid > BTW: the arch_nand_init() or device_nand_init() is the right name > here...Scott need to suggest on this since it involves rework on other > drivers too.
Rather than just change the name, we should do something more similar to Linux, where the driver is called with an initfunc (or explicitly by board/arch code), which in turn calls nand_scan[1], and places itself at the appropriate spot in nand_chip[]. nand_init and nand_init_chip would go away. -Scott [1] Or nand_scan_ident and nand_scan_tail. Some drivers (eLBC) would like to do things in between, but the current driver init mechanism doesn't allow that (so small/large page has to be hardcoded, not detected). It would also allow more than just one address word to be passed to the driver as identification, which would remove some more code and complexity from the eLBC driver. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
