On Thu, 2014-04-10 at 17:37 +0300, Nikita Kiryanov wrote: > On 04/09/2014 06:32 PM, Tim Harvey wrote: > > This presents another challenge for SPL NAND as currently my SPL is > > ~70K. There is a lot of unnecessary code in the mtd nand layer that > > I'm including because that layer includes support for both read and > > write (I don't need write for SPL) as well as various NAND types (and > > I only need BCH). > > > > I'm not sure yet what the best approach is to resolve that. I can either: > > a) add a lot of ifdef's around functions in > > drivers/mtd/nand/{nand_base.c,nand_bbt.c} to remove NAND write and non > > BCH support for CONFIG_SPL_BUILD > > b) re-write the necessary functionality (code duplication) into > > drivers/mtd/nand/mxs_nand_spl.c > > > > Thanks for the review! > > You're welcome. Let's see if the NAND maintainer can offer some > suggestions. > > Cc-ing Scott Wood
While I certainly wouldn't mind someone putting in the effort to slim down the main NAND code, so far we've followed option b when we need a tiny NAND SPL. -Scott _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot