On 3/30/2014 9:30 AM, Stefano Babic wrote: > Hi Troy, > > On 29/03/2014 23:34, Troy Kisky wrote: >> This removes one block in the move toward 1 u-boot >> for both a mx6q (quad) and mx6dl (duallite) processor. >> >> Now fdt_file hardcoded value can be removed. >> >> Signed-off-by: Troy Kisky <troy.ki...@boundarydevices.com> >> --- > > I have a general problem with this implementation. I am ok if, as you > proposed some times ago, there is a general rule for the "default" dtb > file in the CONFIG_EXTRA_ENV. > > However, you are binding in code naming conventions. In U-boot, it must > be allowed to set the environment as the user wants, and this must be > not overwritten by such an internal code.
In the patch, the code returns without any changes if fdt_file is already defined. So, I don't know what you are referring to here. > > I mean: a board user, if he wants, should be allowed to do something as > > setenv fdt_file my_preferred_dtb_name.dtb > > and this must work when the file is loaded from storage - this is not > possible if the rule chosen from user is overwritten by code. I agree, but it does work. > > This makes the environment useless and generates headaches for a lot of > users. They will ask themselves why the wrong file is taken when they > tried in any way to set it differently... Still no disagreement. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
