Hi Masahiro. On 02/24/2014 09:06 AM, Masahiro Yamada wrote: > Hello Michal, > > These files were imported from Linux Kernel. > (drivers/mtd/nand/denali.[ch])
then they should be fixed too. Or better fix kernel driver first and then add these changes to u-boot. Checkpatch in the u-boot is just the same as is in the kernel. > I guess Chin does not want to change the code > unless it is really necessary. > (And I like this way. > We can easily find which parts were adjusted by diffing.) I have no problem that you want to keep that code synchronized for easier diffing but adding incorrect code is just really bad. And you shouldn't just copy what's wrong. > But, good catch! > I think your feedback is highly appreciated for Linux folks. > Can you post your feedback to Linux Kernel? The driver is in mainline from 2010 that's why go and fix it. Make no sense for me to send this to linux kernel because the reaction will be that I should fix it and I have no interest to fix it. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
signature.asc
Description: OpenPGP digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
