Hi Marek,
On Mon, Jan 6, 2014 at 9:22 PM, Marek Vasut <[email protected]> wrote: > On Monday, January 06, 2014 at 10:29:42 AM, Vivek Gautam wrote: >> On smdk5420 two availbale XHCI controllers require VBUS GPIO >> to be configured, the EHCI however doesn't have any such VBUS >> GPIO. So correcting the available board_usb_vbus_init() function >> to the needs. >> >> Signed-off-by: Vivek Gautam <[email protected]> >> --- >> board/samsung/smdk5420/smdk5420.c | 11 ++++++----- >> 1 file changed, 6 insertions(+), 5 deletions(-) >> >> diff --git a/board/samsung/smdk5420/smdk5420.c >> b/board/samsung/smdk5420/smdk5420.c index 3ad2ad0..4f23000 100644 >> --- a/board/samsung/smdk5420/smdk5420.c >> +++ b/board/samsung/smdk5420/smdk5420.c >> @@ -18,14 +18,15 @@ >> >> DECLARE_GLOBAL_DATA_PTR; >> >> -#ifdef CONFIG_USB_EHCI_EXYNOS >> +#ifdef CONFIG_USB_XHCI_EXYNOS >> static int board_usb_vbus_init(void) >> { >> - struct exynos5_gpio_part1 *gpio1 = (struct exynos5_gpio_part1 *) >> - samsung_get_base_gpio_part1(); >> + struct exynos5420_gpio_part4 *gpio4 = (struct exynos5420_gpio_part4 *) >> + samsung_get_base_gpio_part4(); >> >> /* Enable VBUS power switch */ >> - s5p_gpio_direction_output(&gpio1->x2, 6, 1); >> + s5p_gpio_direction_output(&gpio4->g0, 5, 1); >> + s5p_gpio_direction_output(&gpio4->g1, 4, 1); > > This VBUS toggling should happen on per-port basis, right ? No this VBUS gpio toggling is actually enabling the VBUS line of the controller. And since we have 2 controllers on exynos5420, so added the required 2 gpios for the purpose (GPG0[5], and GPG1[4]). > > Best regards, > Marek Vasut > _______________________________________________ > U-Boot mailing list > [email protected] > http://lists.denx.de/mailman/listinfo/u-boot -- Best Regards Vivek Gautam Samsung R&D Institute, Bangalore India _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
