2013.10.24. 12:54 keltezéssel, Paul Burton írta: <...>
>> I agree that it is related to the rename. However renaming the >> mips_boot_qemu_malta constant is a simple cleanup which can be done in a >> preceding patch. The same is true for the CONFIG_QEMU_MALTA->CONFIG_MALTA >> conversion. >> >> In general, renaming a file and altering that within the same patch makes the >> review harder. >> >> -Gabor >> >> > > And for more complex changes I might agree, but only a single file is both > renamed and modified by this patch: include/configs/qemu-malta.h => > include/configs/malta.h. Only a single line is modified within that file, > changing CONFIG_QEMU_MALTA to CONFIG_MALTA. I don't think it's very difficult > to > understand and I think splitting it would be overkill. So if Daniel tells me > (v3 > of) this patch isn't getting in as-is then I'll split it, but short of that > I'm > not changing it. I don't say that it is hard to understand that. Simply the first two version of the patch introduced a regression on older qemu version due to the missing change in mips32/start.S, and it took some time to me to figure out why a rename patch causes such thing. If it would have been a separate change, it would have been obvious. -Gabor _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
