________________________________________ From: Tom Rini [tom.r...@gmail.com] on behalf of Rini, Tom Sent: Saturday, August 24, 2013 3:49 AM To: Gupta, Pekon Cc: scottw...@freescale.com; u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH v2 0/4] mtd: nand: omap: optimize and clean-up of OMAP NAND driver
> On Wed, Aug 14, 2013 at 11:46:51AM +0530, Pekon Gupta wrote: > > [changes in v2] > > - added documentation for CONFIG_NAND_OMAP_xx in doc/README.nand > > - added CONFIG_BCH along with CONFIG_NAND_OMAP_ECC_BCH8_CODE_HW_DETECTION_SW > > to include software library lib/bch.c > > - fixed board_nand_init() and omap_enable_hwecc() > > > > [Original v1] > > This patch series updates BCH8_ECC schemes in mtd/nand/omap_gpmc.c driver > > - adds scalability for higher ECC schemes in future. > > - removes CONFIG_AM335x and it makes it generic for all platforms. > > - optimizes read_data paths > > > > This series is tested for H/W BCH8_ECC scheme on > > - AM335x_EVM and TI814x_EVM > > > > Pekon Gupta (4): > > [PATCH 1/4] mtd: nand: omap: enable BCH ECC scheme usinmg ELM for generic > > platform > > [PATCH 2/4] mtd: nand: omap: optimize chip->ecc.hwctl() for H/W ECC schemes > > [PATCH 3/4] mtd: nand: omap: optimize chip->ecc.calculate() for H/W ECC > > schemes > > [PATCH 4/4] mtd: nand: omap: optimized chip->ecc.correct() for H/W ECC > > schemes > > > > doc/README.nand | 20 ++ > > drivers/mtd/nand/omap_gpmc.c | 514 > > +++++++++++++++---------------------------- > > include/configs/am335x_evm.h | 1 + > > include/configs/ti814x_evm.h | 2 +- > > include/configs/tricorder.h | 2 +- > > 5 files changed, 203 insertions(+), 336 deletions(-) > > Series looks good to me, I'll pick these up soon, after I test them on > beagle as well. > > -- > Tom Thanks Scott and Tom for reviews.. - I just realized few minor cleanup that could help in future. - Also, I'll split the patch-set for AM335x and TI814x boards so that they can be independently tested. So plz wait as I'll post a v3 for this and TI814x series soon, and then may be you can verify them independently. with regards, pekon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
