-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 08/22/2013 06:25 PM, Scott Wood wrote: > On Wed, 2013-08-14 at 11:46 +0530, Pekon Gupta wrote: >> BCH8_ECC scheme implemented in omap_gpmc.c driver has following >> two favours >> +-----------------------------------+-----------------+-----------------+ >> >> >> |ECC Scheme | ECC Calculation | Error Detection | >> +-----------------------------------+-----------------+-----------------+ >> >> >> |OMAP_ECC_BCH8_CODE_HW |GPMC |ELM H/W engine | >> |OMAP_ECC_BCH8_CODE_HW_DETECTION_SW |GPMC |S/W BCH >> library | >> +-----------------------------------+-----------------+-----------------+ >> >> >> >> Current implementation enables of BCH8_CODE_HW only for AM33xx SoC family. >> (using CONFIG_AM33XX). However, other SoC families (like TI81xx) >> also have ELM hardware module, and can support ECC error >> detection using ELM. >> >> This patch - replaces CONFIG_AM33xx define with >> CONFIG_NAND_OMAP_ECC_BCH8_CODE_HW so that all device families >> having required h/w capability can use ELM for error detection >> in ECC_BCHx schemes. >> >> - replaces CONFIG_NAND_OMAP_BCH8 with >> CONFIG_NAND_OMAP_ECC_BCH8_CODE_HW_DETECTION_SW && CONFIG_BCH and >> separates out code for above mentioned BCH8_ECC implementations >> so that driver can be build independently using anyone of them. >> CONFIG_BCH is used to enable software BCH library in lib/bch.c >> >> Signed-off-by: Pekon Gupta <pe...@ti.com> --- doc/README.nand | >> 20 +++++++ drivers/mtd/nand/omap_gpmc.c | 128 >> ++++++++++++++++++++++++------------------- >> include/configs/am335x_evm.h | 1 + >> include/configs/ti814x_evm.h | 2 +- include/configs/tricorder.h >> | 2 +- 5 files changed, 96 insertions(+), 57 deletions(-) > > The ti814x_evm.h changes do not apply. What tree is this against? > > Can someone familiar with the OMAP driver review this patchset?
The ti814x_evm.h part depends on his earlier patch I suspect. If you're happy NAND-wise, I'll pick these up (and formally review 'em, I have skimmed) for the TI tree if that works for you. - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSF1kHAAoJENk4IS6UOR1WpSQP/RKHIQxwNKNhHA1QpwJHBW1w jQcil0HA1GEtovq4YdoYjIENzdVa9pElY+YvkOMy8/sf8CAxgpXDBuFwuJJEkdX7 FVX+HBvMDFvEp7b2epm2Icz2/SQGFMDM2XX1yOT8ojBmuS9vPXylBbQwZBSdq4V8 kdZ4065PtsPZ7ZtH43CwKYEMeYUPLxQOelQZDKY0OZYymfgsuIA7P57g21AD9EtR P+njljb8PHTaTabD35DMKdds3hNy/MYBpZ0VxCWH9O6t6K9eo6TWo+WhEYTyanI+ JE3Dj1YZecyPFLAqdeY6Irz1hGwBtkkS1He6InBsIOlJ5dsjSZmU5ABqNKP8i3Sx 4BypEIo0OUIz8p26DzppSPvy1tvxib2wEY2mDqKKqqhKHwo9XgmJfRDfIYurhKxY N3DgoOPoNuVUKsVFEkD4r9gvlrSyl1wZgRf0sc3qvFQvbOzgIz8AQ+DOPrGTKVGk /HDVH0I9uRkJFtAIBOY5ckygIb0uuzyXc6W7yuNpDu6nVt0Vb4/Uk0OeIBIagbR8 1dN0nqRyu6f4+xwtRF7DrdfgULyAgKnubjr9i0eR6KE+xVdcKq9zStzMCN/hE623 0g/kfVEM8iIPZYb6oxeMx7N2mEe8L/W9lz3bXTibtwCSB+NJF7RjTto7ltT+R9Az 3Nr2HudfhOUBpQISAmyA =cJ/1 -----END PGP SIGNATURE----- _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
