On 08/13/2013 11:44 PM, York Sun wrote:
> On 07/26/2013 03:02 AM, Valentin Longchamp wrote:
>> +
>> +phys_size_t initdram(int board_type)
>> +{
>> +    phys_size_t dram_size = 0;
>> +
>> +    puts("Initializing....");
>> +
>> +    if (fsl_use_spd()) {
>> +            puts("using SPD\n");
>> +            dram_size = fsl_ddr_sdram();
>> +    } else {
>> +            puts("no SPD and fixed parameters\n");
>> +            return dram_size;
>> +    }
> 
> 
> How does the else clause work? You probably want to put an error or
> panic here if you don't have other way to initialize it.
> 

OK I agree.

Valentin

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to