On Mon, Jul 01, 2013 at 11:30:01AM +0200, Frédéric Leroy wrote: > > Le 01/07/2013 00:53, Simon Guinot a écrit : > > On Sun, Jun 30, 2013 at 12:12:29PM +0200, Frédéric Leroy wrote: > > > CloudBox device is device tree compliant, but older LaCie kernel uses > > > machine ID method to boot. > > > > > > Signed-off-by: Frédéric Leroy <fr...@starox.org> > > > [...] > > > +# define machine_cloudbox() (0) > > > +#endif > > > > Hi Fred, > > > > I think you can't update this file directly. Pulling the Linux mach-types > > file is the ARM maintainer job. > > > > Note that for the CloudBox board, the mach-types entry has been removed > > because not needed by Linux. The Linux mainline support is only based on > > DT. I had the same issue with the ns2 lite and mini. At the time, I have > > been told to include the machine ID in the board header: > > http://marc.info/?l=u-boot&m=134694402011372&w=2 > > > > Looks in configs/lacie_kw.h and grep for "missing in mach-types.h". > > There is a doublon for netspace_lite_v2 : > $ git grep MACH_TYPE_NETSPACE_ > arch/arm/include/asm/mach-types.h:#define MACH_TYPE_NETSPACE_LITE_V2 > 2983
This one will probably disappear soon because the Linux support for this board is only based on DT... > [...] > include/configs/lacie_kw.h:#define MACH_TYPE_NETSPACE_LITE_V2 2983 /* > missing in mach-types.h */ > > > Besides, I don't understand why do you need a separate patch to add the > > legacy boot support. > > Partly because I added CloudBox without it and it seems logical to add > it after, > partly because I was not sure of the change of mach_types.h :) > > I am not at ease with sending patch to the ML and with patchwork. > How should I send the fix ? > A new v3 patch including all but " lacie_kw: sort #ifdef lists by > CONFIG_ identifiers" > and "LaCie/common: Fix cloudbox ethernet leds", > or just a v3 of "arm: add machine ID for CloudBox" ? I think that you must resend the whole patch series even if you keep some patches unchanged. Regards, Simon
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
