-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Le 01/07/2013 00:53, Simon Guinot a écrit : > On Sun, Jun 30, 2013 at 12:12:29PM +0200, Frédéric Leroy wrote: > > CloudBox device is device tree compliant, but older LaCie kernel uses > > machine ID method to boot. > > > > Signed-off-by: Frédéric Leroy <fr...@starox.org> > > [...] > > +# define machine_cloudbox() (0) > > +#endif > > Hi Fred, > > I think you can't update this file directly. Pulling the Linux mach-types > file is the ARM maintainer job. > > Note that for the CloudBox board, the mach-types entry has been removed > because not needed by Linux. The Linux mainline support is only based on > DT. I had the same issue with the ns2 lite and mini. At the time, I have > been told to include the machine ID in the board header: > http://marc.info/?l=u-boot&m=134694402011372&w=2 > > Looks in configs/lacie_kw.h and grep for "missing in mach-types.h".
There is a doublon for netspace_lite_v2 : $ git grep MACH_TYPE_NETSPACE_ arch/arm/include/asm/mach-types.h:#define MACH_TYPE_NETSPACE_LITE_V2 2983 [...] include/configs/lacie_kw.h:#define MACH_TYPE_NETSPACE_LITE_V2 2983 /* missing in mach-types.h */ > Besides, I don't understand why do you need a separate patch to add the > legacy boot support. Partly because I added CloudBox without it and it seems logical to add it after, partly because I was not sure of the change of mach_types.h :) I am not at ease with sending patch to the ML and with patchwork. How should I send the fix ? A new v3 patch including all but " lacie_kw: sort #ifdef lists by CONFIG_ identifiers" and "LaCie/common: Fix cloudbox ethernet leds", or just a v3 of "arm: add machine ID for CloudBox" ? - -- Frédéric -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQGcBAEBAgAGBQJR0UwZAAoJEJVX96CfzRSesw8MAKpUfwRAwe8beLAuHUf1xWTh XksHGVuWOoI/lyAuz8AxcnE/EjbzliLGV0k0qDsWxlmVga425VxrY8d5/qZL55Z8 F95yo0aZ1q3EPTaSwjKVTUntJm8WOJesf6cK3YQqTO/1b+hrP+NCGBFL4+vNFPPL 9jtKkMjhOSa+f6X/fIhcCiqATUkX22SRheX7osoLxHFOTQ8baJLxf2Bt0L/g2KRA t36WCYAqENx727LUIYdT3+B9tEEpc2fpCma2CRMmDjKgFrdbyOik/B7+mtk6Pyla xoXQs7rV2OBYUYV2CBwQKfqBHIhrqazWcA+a5M13P90xyLjWJ/RoTAs/a9iMHNwO xyvaDCafIJBloq+GXlkwewQfxZ2AkKADP+Q47hGkYYX8YOCOJ4bz+OQ/UT/M+LJK pg0LBwjj8CUI6FpdxJWvDvxORpBFHPxDXjuz/rMenblph0cAEJH4O9BOlVUUkahw E7/W9U0koVaEKg6Uegmuert1SSDSJwBHRdB+tXljMg== =dDRp -----END PGP SIGNATURE----- _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
