> -----Original Message----- > From: Stephen Warren [mailto:swar...@wwwdotorg.org] > Sent: Friday, May 03, 2013 12:40 AM > To: Jim Lin > Cc: u-boot@lists.denx.de; ma...@denx.de; Stephen Warren; Tom Warren; > Venu Byravarasu > Subject: Re: [U-Boot] [PATCH 1/3] ARM: Tegra: FDT: Add USB support for > T20/T30/T114 > > On 04/29/2013 03:21 AM, Jim Lin wrote: > > Add DT node for USB function. > > > diff --git a/arch/arm/dts/tegra114.dtsi b/arch/arm/dts/tegra114.dtsi > > > +/* This table has USB timing parameters for each Oscillator frequency we > > + * support. There are four sets of values: > > + *
>
> The same comment applies to all 3 tegra*.dtsi files. For the Tegra20
> case, please make sure that what you add here is identical to what has
> been proposed for the final kernel USB bindings. Ask Venu (now CC'd) for
> a pointer to that.
Plz see attached file for finalized Tegra20 DT bindings.
>
> > + usb@7d000000 {
> > + compatible = "nvidia,tegra30-ehci", "nvidia,tegra114-ehci";
> > + reg = <0x7d000000 0x4000>;
> > + interrupts = < 52 >;
>
> There shouldn't be spaces after < or before >.
>
> The bindings here don't match the kernel. Please make sure they do.
>
> This patch only touches 2 board files: Cardhu and Dalmore. Will USB
> support on other boards continue to work without any DT changes?
> Existing functionality can't be broken. I'd expect to see a bunch more
> DT files edited here.
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may
contain
confidential information. Any unauthorized review, use, disclosure or
distribution
is prohibited. If you are not the intended recipient, please contact the
sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
0001-ARM-tegra-finalize-USB-EHCI-and-PHY-bindings.patch
Description: 0001-ARM-tegra-finalize-USB-EHCI-and-PHY-bindings.patch
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
