Hi Tom, On Thu, Feb 21, 2013 at 9:50 AM, Tom Rini <tr...@ti.com> wrote: > On Wed, Feb 20, 2013 at 04:36:21PM +0800, Sonic Zhang wrote: >> Hi Wolfgang, >> >> On Tue, Feb 19, 2013 at 6:14 PM, Wolfgang Denk <w...@denx.de> wrote: >> > Dear Sonic Zhang, >> > >> > please provide a useful Subject: line - "*** SUBJECT HERE ***" is not >> > exactly helpful. >> > >> > In message <1361257266-3722-1-git-send-email-sonic....@gmail.com> you >> > wrote: >> >> >> >> The v2 patches >> >> 1) fix most checkpatch issues mentioned by Wolfgang >> > >> > Hm... I'm sorry, but this information is not really helpful. So it >> > seems you decided not to fix all issues, but you don't tell us which >> > ones you ignored, or why. >> > >> > I still see thousands of lines over 80 characters, >> > plus a number of >> > trailing statements should be on next line, >> > code indent should use tabs where possible, >> > do not add new typedefs, >> > Whitespace before semicolon, >> > warnings and errors. >> > >> > Please fix these!! >> > >> >> Sorry, I forget to check the serial patch after fixing the unreadable >> port muxing code. >> But, where is the "Whitespace before semicolon"? my checkpatch.pl >> doesn't report this issue. >> >> >> 2) remove unrelated dma structure change patch >> >> 3) replace unreable macro in dma and uart structures with normal types. >> >> 4) replace unreable macro in uart peripheral portmux configuration with >> >> clear inline function. >> >> 5) clean up and merge redundant #ifdef's >> >> 6) spearate declarations and code by a blankline >> >> 7) remove the values for variables in blackfin config headers whose >> >> values are useless >> >> 8) replace run-time variable with new macro when adding 4M byte CPLB >> >> entries. >> > >> > Please provide a more detailed list which review comments you >> > processed, and which you decided to ignore, and why. >> > >> > Please provide a more detailed list which review comments you >> > processed, and which you decided to ignore, and why. >> > >> > Note: this history of changes is supposed to be (also) in the patches >> > itself, not (only) in the cover letter. >> > >> >> OK. I will put all change logs into the patches respectively. > > Making use of patman (see tools/patman) can help both in that it will > generate the emails for you, based on you adding the right information > to your commits, and it will run the same checkpatch that Wolfgang is > running as well. >
Thank you for your guide. I don't know these helpful script before. I will send out v4 patches in the way you recommended. Regards, Sonic _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
