Dear Sonic Zhang,
please provide a useful Subject: line - "*** SUBJECT HERE ***" is not
exactly helpful.
In message <1361257266-3722-1-git-send-email-sonic....@gmail.com> you wrote:
>
> The v2 patches
> 1) fix most checkpatch issues mentioned by Wolfgang
Hm... I'm sorry, but this information is not really helpful. So it
seems you decided not to fix all issues, but you don't tell us which
ones you ignored, or why.
I still see thousands of lines over 80 characters,
plus a number of
trailing statements should be on next line,
code indent should use tabs where possible,
do not add new typedefs,
Whitespace before semicolon,
warnings and errors.
Please fix these!!
> 2) remove unrelated dma structure change patch
> 3) replace unreable macro in dma and uart structures with normal types.
> 4) replace unreable macro in uart peripheral portmux configuration with clear
> inline function.
> 5) clean up and merge redundant #ifdef's
> 6) spearate declarations and code by a blankline
> 7) remove the values for variables in blackfin config headers whose values
> are useless
> 8) replace run-time variable with new macro when adding 4M byte CPLB entries.
Please provide a more detailed list which review comments you
processed, and which you decided to ignore, and why.
Please provide a more detailed list which review comments you
processed, and which you decided to ignore, and why.
Note: this history of changes is supposed to be (also) in the patches
itself, not (only) in the cover letter.
Thanks.
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
You don't get paid for the hour. You get paid for the value you bring
to the hour. - Jim Rohn
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
