Hi Wolfgang, On Tue, Feb 19, 2013 at 6:14 PM, Wolfgang Denk <w...@denx.de> wrote: > Dear Sonic Zhang, > > please provide a useful Subject: line - "*** SUBJECT HERE ***" is not > exactly helpful. > > In message <1361257266-3722-1-git-send-email-sonic....@gmail.com> you wrote: >> >> The v2 patches >> 1) fix most checkpatch issues mentioned by Wolfgang > > Hm... I'm sorry, but this information is not really helpful. So it > seems you decided not to fix all issues, but you don't tell us which > ones you ignored, or why. > > I still see thousands of lines over 80 characters, > plus a number of > trailing statements should be on next line, > code indent should use tabs where possible, > do not add new typedefs, > Whitespace before semicolon, > warnings and errors. > > Please fix these!! >
Sorry, I forget to check the serial patch after fixing the unreadable port muxing code. But, where is the "Whitespace before semicolon"? my checkpatch.pl doesn't report this issue. >> 2) remove unrelated dma structure change patch >> 3) replace unreable macro in dma and uart structures with normal types. >> 4) replace unreable macro in uart peripheral portmux configuration with >> clear inline function. >> 5) clean up and merge redundant #ifdef's >> 6) spearate declarations and code by a blankline >> 7) remove the values for variables in blackfin config headers whose values >> are useless >> 8) replace run-time variable with new macro when adding 4M byte CPLB entries. > > Please provide a more detailed list which review comments you > processed, and which you decided to ignore, and why. > > Please provide a more detailed list which review comments you > processed, and which you decided to ignore, and why. > > Note: this history of changes is supposed to be (also) in the patches > itself, not (only) in the cover letter. > OK. I will put all change logs into the patches respectively. Regards, Sonic _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
