Dear Sonic Zhang, In message <cajxxz0otwow6x2kx8yaujtrxc6qicvpmo2rp4mhwjqvqubh...@mail.gmail.com> you wrote: > > >> @@ -113,16 +131,19 @@ static int sdh_setup_data(struct mmc *mmc, struct > >> mmc_data *data) > > ... > >> - int ret = 0; > > ... > >> - return ret; > >> + return 0; > > > > If this function can always only return 0, then please make it void. > > > > Please fix globally. > > I am sorry, this function can't be changed to void, because it may > return error. See bellow code.
You are contradicting yourself. You _always_ return a 0 here. Your code CANNOT return an error code. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Build a system that even a fool can use and only a fool will want to use it. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
