Dear Sonic Zhang,
In message <1360223258-6945-3-git-send-email-sonic....@gmail.com> you wrote:
> From: Sonic Zhang <sonic.zh...@analog.com>
>
> Set up clocks, DDR controller, Nor flash controller, reboot,
> serial port. Add new SPI boot modes.
Checkpatch issues, please fix.
> +#ifndef __ADSPBF60x__
> +#include <asm/mach-common/bits/pll.h>
> +#else
> +#include <asm/mach-common/bits/cgu.h>
> +#endif
General question: you add a _lot_ of new #ifdef's all over the place.
Also, I think I see lots of duplicated (or very similar) code.
Can this not be avoided?
> if (BFIN_DEBUG_EARLY_SERIAL) {
> - int ucen = bfin_read16(&pUART->gctl) & UCEN;
> + int enabled = serial_early_enabled(uart_base);
> serial_early_init(uart_base);
Please spearate declarations and code by a blankline. Please fix
globally (at least where you touch the code anyway).
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Successful and fortunate crime is called virtue. - Seneca
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
