Dear "Prodyut Hazarika", In message <[EMAIL PROTECTED]> you wrote: > > I basically moved the defines from include/ppc440.h to include/ppc4xx.h. > If you go to include/ppc440.h, you will see that the original define was > aligned > With spaces. I just followed whatever was it. > > Here is the original code in ppc440.h > > #if defined(CONFIG_440EP) || defined (CONFIG_440GR) || \ > ^^ space here ^^ space here > defined(CONFIG_440EPX) || defined(CONFIG_440GR) > ^^^^^space here
This is not what we are talking about. This part of the code is OK. I was complaining about this part: > diff --git a/include/asm-ppc/ppc4xx-sdram.h b/include/asm-ppc/ppc4xx-sdram.h > index df787b3..d2e3b42 100644 > --- a/include/asm-ppc/ppc4xx-sdram.h > +++ b/include/asm-ppc/ppc4xx-sdram.h > @@ -259,23 +259,39 @@ > /* > * Memory queue defines > */ > -#define SDRAMQ_DCR_BASE<<<>>>0x040 > - > -#define SDRAM_R0BAS<>SDRAMQ_DCR_BASE+0x0)<<>>/* rank 0 base address & size > */ > -#define SDRAM_R1BAS<>(SDRAMQ_DCR_BASE+0x1)<>>/* rank 1 base address & size > */ > -#define SDRAM_R2BAS<>(SDRAMQ_DCR_BASE+0x2)<>>/* rank 2 base address & size > */ > -#define SDRAM_R3BAS<>(SDRAMQ_DCR_BASE+0x3)<>>/* rank 3 base address & size > */ > -#define SDRAM_CONF1HB<<<<>>>>(SDRAMQ_DCR_BASE+0x5)<>>/* configuration 1 HB > */ > -#define SDRAM_ERRSTATHB<<<>>>(SDRAMQ_DCR_BASE+0x7)<>>/* error status HB > */ > -#define SDRAM_ERRADDUHB<<<>>>(SDRAMQ_DCR_BASE+0x8)<>>/* error address upper > 32 HB */ > -#define SDRAM_ERRADDLHB<<<>>>(SDRAMQ_DCR_BASE+0x9)<>>/* error address lower > 32 HB */ > -#define SDRAM_PLBADDULL<<<>>>(SDRAMQ_DCR_BASE+0xA)<>>/* PLB base address > upper 32 LL */ > -#define SDRAM_CONF1LL<<<<>>>>(SDRAMQ_DCR_BASE+0xB)<>>/* configuration 1 LL > */ > -#define SDRAM_ERRSTATLL<<<>>>(SDRAMQ_DCR_BASE+0xC)<>>/* error status LL > */ > -#define SDRAM_ERRADDULL<<<>>>(SDRAMQ_DCR_BASE+0xD)<>>/* error address upper > 32 LL */ > -#define SDRAM_ERRADDLLL<<<>>>(SDRAMQ_DCR_BASE+0xE)<>>/* error address lower > 32 LL */ > -#define SDRAM_CONFPATHB<<<>>>(SDRAMQ_DCR_BASE+0xF)<>>/* configuration > between paths */ > -#define SDRAM_PLBADDUHB<<<>>>(SDRAMQ_DCR_BASE+0x10)<>/* PLB base address > upper 32 LL */ > +#define SDRAMQ_DCR_BASE 0x040 > + > +#define SDRAM_R0BAS (SDRAMQ_DCR_BASE+0x0) /* rank 0 base address & > size */ ----------------------^^^^^^--------------------^^^ all spaces here > +#define SDRAM_R1BAS (SDRAMQ_DCR_BASE+0x1) /* rank 1 base address & > size */ > +#define SDRAM_R2BAS (SDRAMQ_DCR_BASE+0x2) /* rank 2 base address & > size */ > +#define SDRAM_R3BAS (SDRAMQ_DCR_BASE+0x3) /* rank 3 base address & > size */ > +#define SDRAM_CONF1HB (SDRAMQ_DCR_BASE+0x5) /* configuration 1 HB > */ > +#define SDRAM_CONF1HB_AAFR 0x80000000 /* Address Ack on First > Request - Bit 0 */ > +#define SDRAM_CONF1HB_PRPD 0x00080000 /* PLB Read pipeline Disable > - Bit 12 */ > +#define SDRAM_CONF1HB_PWPD 0x00040000 /* PLB Write pipeline > Disable - Bit 13 */ > +#define SDRAM_CONF1HB_PRW 0x00020000 /* PLB Read Wait - Bit 14 */ > +#define SDRAM_CONF1HB_RPEN 0x00000800 /* Read Passing Enable - Bit > 20 */ > +#define SDRAM_CONF1HB_RFTE 0x00000400 /* Read Flow Through Enable > - Bit 21 */ ... -------------------------^^^----------^^^^^^^^^ allspeace here I marked the places in the original part that were actually TAB characters by sequences of "<<>>" so you can see what I mean. [Actually, the comment-end markers "*/" should be aligned by TABs, too.] Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] Making files is easy under the UNIX operating system. Therefore, users tend to create numerous files using large amounts of file space. It has been said that the only standard thing about all UNIX systems is the message-of-the-day telling users to clean up their files. - System V.2 administrator's guide _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
