> > > > It would be nice if the commit messages contained at least a minimal > > explanation of the reasons for the changes. > >Yes, the original comment from Prodyut is gone. Please add it again.
The original comments got omitted by mistake. I will resubmit it again. > > > +#define plb1_bearl (PLB_ARBITER_BASE+ 0x0C) > > > +#define plb1_bearh (PLB_ARBITER_BASE+ 0x0D) > > > + > > > +#endif /* 440EP/EPX 440GR/GRX 440SP/SPE 460EX/GT/SX 405EX*/ > > > + > > > > Here you move 44x specific code from a 44x specific header file into a > > 4xx generic header file which requires you to add a 44x specific > > #ifdef's. > > These defines are also used on the 405EX (and possibly future 405 variants as > well). It makes sense to move them to ppc4xx.h so we don't have to duplicate > those defines in 2 headers. This has been a big problem in the past with the > ppc405.h and ppc440.h headers. I will move the PPC405EX to the beginning of the list and resubmit. Best regards, Prodyut Hazarika ========================= Staff Software Engineer AMCC ========================= -------------------------------------------------------- CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and contains information that is confidential and proprietary to Applied Micro Circuits Corporation or its subsidiaries. It is to be used solely for the purpose of furthering the parties' business relationship. All unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of the original message.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
