On Wednesday, 11 September 2013 17:45:02 CEST, Pali Rohár wrote:
First version of code is in my pali-gsoc branch.
Looks like you based your code on something from cmake's git. Could you please make a separate commit that adds the original file (possibly under the new name, not the original one, that's not important), and make your changes on top of that? This way, we can see what has changed and know whom to ask for support five years in future.
+ trojita_find_package(Qt5Gui "" "" "" "" REQUIRED) + trojita_find_package(Qt5Network "" "" "" "" REQUIRED) + trojita_find_package(Qt5Sql "" "" "" "" REQUIRED) + trojita_find_package(Qt5WebKitWidgets "" "" "" "" REQUIRED) + trojita_find_package(Qt5LinguistTools "" "" "" "") + trojita_find_package(Qt5LinguistForTrojita "" "" "" "") + trojita_find_package(Qt5DBus "" "" "" "" WITH_DBUS) + trojita_find_package(Qt5Test "" "" "" "" WITH_TESTS)
This is a big no-no -- Qt is such a core thing that it doesn't make sense to introduce any custom dependency checking on top of that. Please leave this as-is, we might even want to replace that with another way of deps altogether (qt5_use_modules).
Also do not work towrads making the tests automagic -- the default build shall always run the tests, not proceed with the build and skipping the test when the qttest is not available. It's OK to give the user a way of manually opting out of the tests, but it is not OK to have this automatic when QtTest is not there, in my opinion.
I'm still not sold on the idea of "static plugins" besides the passwords-in-qsettings, so I have ignored that part of the patch.
Cheers, Jan -- Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/
