Actually without -d the focus hasn;t changed, it is still on the same
pane, so you won't need to do anything.
With -d, you need to unfocus the moved pane and focus the newly focused
one in the window it was in.
On Tue, Feb 19, 2013 at 04:17:44PM +0000, Nicholas Marriott wrote:
> On Tue, Feb 19, 2013 at 07:37:54AM -0800, Aaron Jensen wrote:
> > Awesome, thanks for the comments. I pinged akracun as well. One of us
> > will
> > put together a new patch. Questions inline.
> >
> > On Tuesday, February 19, 2013 at 1:03 AM, Nicholas Marriott wrote:
> >
> > + window_pane_focus_notify(w->active, 1);
> >
> > We can't apply it with all these little // comments, can you remove
> > them?
> > Also the position of this call doesn't seem right, break-pane doesn't
> > change the focus with -d.
> >
> > I think more needs to be done here. break-pane with -d does change focus,
> > it focuses the other pane in the current window. I'll need to look into
> > exactly how this is done, we may actually be missing an unfocus notify
> > here. Also, this should only happen in the -d case I believe. Does that
> > seem right?
>
> Oh you're right, so yes you will need to notify here. And it will happen
> with and without -d because the other pane has gone away.
>
> >
> > /* Termcap codes. */
> > @@ -917,6 +920,8 @@ struct window_pane {
> > int flags;
> > #define PANE_REDRAW 0x1
> > #define PANE_DROP 0x2
> > + int focus_notify;
> > +#define PANE_FOCUS_NOTIFY 0x1
> >
> > Why is this a window pane flag rather than a screen mode like the other
> > mouse stuff and whatnot?
> > Even if that is better, let's just put this in the flags field rather
> > than adding another member.
> >
> > Good question. My guess is that since akracun originally wrote it without
> > the window switching handling he originally envisioned it as a window
> > feature, but I won't put works in his mouth. Now that it handles window
> > switching I think that making it screen mode makes sense. Do you have a
> > preference?
>
> I think it should go in as a screen mode flag same as the other stuff.
>
> Thanks
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb
_______________________________________________
tmux-users mailing list
tmux-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tmux-users
