On Wed, Jan 30, 2013 at 11:14 AM, Thomas Adam <tho...@xteddy.org> wrote:
> I've pushed changes to tmux.git which means you'll need to rework your
> patch slightly since GRID_FLAG_UTF8 is no longer used by anything.
>
> You're probably OK to just call grid_cell_{get,set}() without checking
> first; but I've not looked.
>
Oh, well, I guess I didn't really need to debug that problem after all. I
have rebased to HEAD and reverted my commit to fix the UTF-8 issue, and the
code seems to run just fine.
Nicholas wrote:
> I think we should make this a flag to resize-pane (I suggest -R or -L)
> rather than a new command. Could you do that?
Those flags are taken. I have chosen -F, as in reFlow. So now, just
"resize-pane -F" simply reflows the pane without any other adjustments.
Incidentally, the man page entry for resize-pane doesn't seem to reflect
reality: -U isn't a real default. This serves my purposes nicely, as it
turns out. Let me know if you want me to rewrite the man page entry for
resize-pane (perhaps as a separate patch/thread).
Taking out reflow-pane reduces the size of the patch significantly, which
is good.
I'm not sure we need the GRID_DEBUG now if you are happy it works?
Gone.
In any case these declarations need to go before the GRID_DEBUG lines or
> it will fail when built with gcc2. Same in several places below.
> I'm going to add -Wdeclaration-after-statement to CFLAGS I think...
I see. If you need to build on a compiler that can't handle that, then
having that warning sounds like an excellent idea. I have also pulled up
"struct grid_line *gl" in that same function so as to be more consistent
(even though it is at the top of a block, so should be OK).
Fresh complete patch rebased on c4c98df4f25a5681fcc8da3394cf4adf39f56893
attached.
tmux.patch
Description: Binary data
------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_jan
_______________________________________________ tmux-users mailing list tmux-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tmux-users
