I think an argument rather than a flag would be better TBH, don't see a flag as being useful.
On Fri, Feb 01, 2013 at 08:28:10AM +0000, Thomas Adam wrote: > Hi, > > On 1 February 2013 07:15, Richard Woodbury <rpwoo...@google.com> wrote: > > On Thu, Jan 31, 2013 at 6:55 AM, Nicholas Marriott > > <nicholas.marri...@gmail.com> wrote: > >> > >> Ok let's lose the option and make it the default and that means we don't > >> have to have resizep -F and that means no man page changes too. > >> > >> I think I would try to put the call to grid_reflow into screen_resize > >> but it will need an extra argument because we still won't want to do it > >> in alternate screen, for the calls in window-copy.c etc. > >> > >> Richard, can you do these changes? If not I will try to do them > >> tomorrow. > > > > > > I'm excited you want to make reflowing the new behavior for tmux. All of > > these changes yield a substantially simplified patch. However, along the way > > I lost your "alternate screen" tweak, and I haven't yet wired it up to work > > within screen_resize(). Here's what I have so far; if you get a chance, > > perhaps you could wire it up, otherwise I can hack on it more tomorrow > > evening. > > There's two ways of doing this. Either, we change the arity of > screen_resize() to accept an additional argument to say whether or not > it expects to reflow, and then change all occurrences where > screen_resize(0 is used (there aren't many); or, we add a flag to > struct screen, to indicate whether we expect that to reflow. The flag > approach has other niceties in that it then allows other callers to > know the state globally, rather than coding that decision in each call > to screen_resize(). > > But I'll let Nicholas decide. :) > > -- Thomas Adam ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_jan _______________________________________________ tmux-users mailing list tmux-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tmux-users
