Hi, I'm sorry that I don't have time to debug this right now...
On 29 January 2013 18:27, Richard Woodbury <rpwoo...@google.com> wrote: > On Tue, Jan 29, 2013 at 7:15 AM, Nicholas Marriott > <nicholas.marri...@gmail.com> wrote: >> >> Can you send a unified diff to the mailing list please? > > Sure thing. See below. Your patch segfaults tmux when I do this: tmux -Stemp -Ltemp -f/dev/null ^b:setw reflow ^b" (That is, start tmux on a new server with your patch compiled; immediately set the 'reflow' option on the window; then call 'splitw' on it.) Stack trace below: #0 0x08061675 in grid_utf8_size (gu=0x0) at grid-utf8.c:36 36 if (gu->data[size] == 0xff) (gdb) bt #0 0x08061675 in grid_utf8_size (gu=0x0) at grid-utf8.c:36 #1 0x080828d1 in tty_pututf8 (tty=0x284e2090, gu=0x0) at tty.c:423 #2 0x0808476d in tty_cell (tty=0x284e2090, gc=0x2859b2db, gu=0x0) at tty.c:1107 #3 0x08083114 in tty_draw_line (tty=0x284e2090, s=0x2840fab4, py=0, ox=0, oy=0) at tty.c:624 #4 0x0806f596 in screen_redraw_screen (c=0x284d2000, status_only=0, borders_only=0) at screen-redraw.c:254 #5 0x08074367 in server_client_check_redraw (c=0x284d2000) at server-client.c:644 #6 0x08073e3c in server_client_loop () at server-client.c:487 #7 0x0807712e in server_loop () at server.c:204 #8 0x080770f1 in server_start (lockfd=6, lockfile=0x28420780 "") at server.c:192 #9 0x0804be35 in client_connect (path=0x80b7160 "foo", start_server=1) at client.c:124 #10 0x0804c081 in client_main (argc=0, argv=0xbfbfe568, flags=1) at client.c:220 #11 0x0807fe74 in main (argc=0, argv=0xbfbfe568) at tmux.c:408 (gdb) I suspect the point at which you create the new grid when 'reflow' is set isn't liking the assignment to the new pane when it gets created, but I've not checked. It's not as simple as checking gu for being NULL, either. :P -- Thomas Adam ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnnow-d2d _______________________________________________ tmux-users mailing list tmux-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tmux-users
