Dear Evgen, Thank you so much for your willingness to share together in work. Your patch is perfectly submitted. I've reviewed it and at first glance, I see that you've changed:
-Song of Solomon=Песня Песней +Song of Solomon=Песнь Песней But in the parsing section [Book Abbrevs], you still have: ПЕСНЯ ПЕСНЕЙ=Song This is likely to cause trouble. All references need to successfully parse "round-trip", so if we return Песнь Песней for the book of Song of Solomon, then we need to be able to parse this as a book name, but there is no appropriate entry: ПЕСНЬ ПЕСНЕЙ=Song There can be as many entries as a user might type to match the book name, so you can either add the new entry, in case ПЕСНЯ is still valid, but if it was simply a typo, then you can modify the existing entry. These also accommodate partial matches, e.g., if the user types ПЕС then there are a number of entries already in that file which will match and work which all point to Song. I hope this helps explain the sections a bit better. I didn't review every change. Could you update the Song entry either way you would like and consider any other changes you might need to make. Thank you again! Troy On 4/25/21 6:43 PM, Evgen Kucherov wrote: > > Hi, > > Thank you, everybody for your input. After thinking about it a bit > more I decided to drop the hyphen "-" completely. > > "1 Коринтян" is a nice concise way to display the book name. A > complete way would be "Перше послання до Коринтян" or "1-ше послання > до Коринтян" which is too long for the purpose in my understanding. > > > Attached is the complete patch with [Pref Abbrevs] section for > Ukrainian and without hyphen > > > Is the following understanding of the sections correct? > > [Text] - used by frontends to display a localized list of book names > for user to choose a book > > [Pref Abbrevs] - used as preferred abbreviations for cross-references > and other compact mentions > > [Book Abbrevs] - all possible variants to spell the book name for > user's "type-in-quick-jump" to a book > > > Am I missing something? > > > /sincerely,/ > /Evgen Kucherov/ > > _______________________________________________ > sword-devel mailing list: sword-devel@crosswire.org > http://crosswire.org/mailman/listinfo/sword-devel > Instructions to unsubscribe/change your settings at above page
_______________________________________________ sword-devel mailing list: sword-devel@crosswire.org http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page
