> On Jun 14, 2015, at 12:07, Adrian Chadd <adr...@freebsd.org> wrote: > >> On 14 June 2015 at 12:02, Garrett Cooper <yaneurab...@gmail.com> wrote: >> >>> On Jun 14, 2015, at 11:53, Adrian Chadd <adr...@freebsd.org> wrote: >>> >>> We have busybox already - it's called bsdbox, and it's in base, and >>> we're already using it, and yes, it does pull in libxo. :) >>> >>> I'm not worried about the size increase of libxo. That's the wrong >>> thing to focus on. If it gets much more bloated then I'll poke people >>> with the big "what are you thinking" stick. The issues people have >>> aren't size related, they're "this API needs improvement and we have >>> bugs introduced into tools." >>> >>> I do like how zero percent of the comments are "hey, maybe we need >>> unit tests that run these tools and ensure they output the right >>> stuff." If this were ${WORK} and I were ${BOSS}, I'd have asked the >>> libxo developers to include unit tests before/after for each thing >>> they broke, so we don't have a repeat of this kind of thing. But, this >>> apparently isn't ${WORK} and I definitely don't want to be anyones >>> boss, so.. >> >> Ugh. I'll write the tests ;(... > > I'm not your boss! > > (but if you go and do it - great! thankyou! This is what should've > been neckbearded, not the rest of the thread!)
A part of it, yeah.. Not having manpqges still makes it annoying when I have to figure out how things work ;(. Next time someone else converts ANYTHING to libxo -- write tests FIRST to make sure you're not breaking legacy behavior. If you need help figuring out how to do that, I'll be more than happy to document it on a wiki page, with simple, concise directions. Thanks! _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"