@henningw commented on this pull request.
> @@ -440,7 +451,15 @@ int pv_fetch_contacts(
return -1;
}
- ptr = 0; //r->contacts;TODO
+ rpp->impi.s = (char *)pkg_malloc(r->private_identity.len *
sizeof(char));
+ if(rpp->impi.s == NULL) {
+ LM_ERR("no mem for impi\n");
+ return -1;
My expection would be that if a script function fails, there is no need to
cleanup necessary in the kamailio cfg. So we should do a proper cleanup here
and also in line 439. If you compare to the standard registrar module function,
it also just uses the "goto error" logic.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4166#discussion_r2038928499
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4166/review/2759348...@github.com>_______________________________________________
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the
sender!
