@henningw commented on this pull request.
> @@ -423,7 +434,7 @@ int pv_fetch_contacts(
rpp->aor.s = (char *)pkg_malloc(aor.len * sizeof(char));
if(rpp->aor.s == NULL) {
LM_ERR("no more pkg\n");
- return -1;
+ goto error;
Sorry to be annoying, but I would prefer to keep the -1 here, as we are not
having any memory allocated yet, and to also stay in sync with the main
registrar module implementation
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4166#pullrequestreview-2759394123
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4166/review/2759394...@github.com>_______________________________________________
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the
sender!
