@lyatanski commented on this pull request.
> @@ -455,8 +474,8 @@ int pv_fetch_contacts(
goto error;
}
memcpy(c0, ptr, ilen);
- //c0->domain = {0,0};//NULL;TODO
- //c0->aor = {0,0};//NULL;
+ c0->domain = (str){NULL, 0};
there is compilation error without it. I assume this is the reason it was
commented out and although it is not being used, it would probably be better to
be initialized/zerroed.
I doubt it is related to particular compiler version, but with `gcc (Alpine
14.2.0) 14.2.0` I get:
```
Building C object
src/modules/ims_registrar_scscf/CMakeFiles/ims_registrar_scscf.dir/regpv.c.o
FAILED:
src/modules/ims_registrar_scscf/CMakeFiles/ims_registrar_scscf.dir/regpv.c.o
/usr/bin/cc -DADAPTIVE_WAIT -DADAPTIVE_WAIT_LOOPS=1024 -DARCH=\"x86_64\"
-DCC_GCC_LIKE_ASM -DCFG_DIR=\"/usr/local/etc/kamailio/\" -DCOMPILER="\"gcc
14.2.0\"" -DDBG_SR_MEMORY -DDISABLE_NAGLE -DDNS_IP_HACK -DFAST_LOCK -DFMSTATS
-DF_MALLOC -DHAVE_ALLOCA_H -DHAVE_EPOLL -DHAVE_GETHOSTBYNAME2 -DHAVE_IP_MREQN
-DHAVE_MSGHDR_MSG_CONTROL -DHAVE_MSG_NOSIGNAL -DHAVE_RESOLV_RES
-DHAVE_SCHED_SETSCHEDULER -DHAVE_SCHED_YIELD -DHAVE_SELECT -DHAVE_SIGIO_RT
-DHAVE_TIMEGM -DHAVE_UNION_SEMUN -DKMSTATS -DKSR_PTHREAD_MUTEX_SHARED
-DMALLOC_STATS -DMOD_NAME=\"ims_registrar_scscf\"
-DMOD_NAMEID=ims_registrar_scscf -DNAME=\"kamailio\" -DOS=Linux
-DOS_QUOTED=\"Linux\" -DPKG_MALLOC -DQ_MALLOC -DRAW_SOCKS
-DRUN_DIR=\"/run/kamailio\" -DSHARE_DIR=\"/usr/local/share/kamailio/\"
-DSHM_MMAP -DSIGINFO64_WORKAROUND -DSTATISTICS -DTLSF_MALLOC -DTLS_HOOKS
-DUSE_DNS_CACHE -DUSE_DNS_FAILOVER -DUSE_DST_BLOCKLIST -DUSE_MCAST -DUSE_NAPTR
-DUSE_RAW_SOCKS -DUSE_SCTP -DUSE_TCP -DUSE_TLS -DVERSION=\"6.1.0-dev0\"
-DVERSIONVAL=6001000 -D__CPU_x86_64 -D__OS_linux -Dims_registrar_scscf_EXPORTS
-isystem /usr/include/libxml2 -O3 -DNDEBUG -std=gnu11 -fPIC
-ffile-prefix-map=/code/src/modules/ims_registrar_scscf/= -fPIC -Wall
-funroll-loops -Wcast-align -Werror=implicit-function-declaration
-Werror=implicit-int -m64 -minline-all-stringops -falign-loops -ftree-vectorize
-fno-strict-overflow -mtune=generic -MD -MT
src/modules/ims_registrar_scscf/CMakeFiles/ims_registrar_scscf.dir/regpv.c.o
-MF
src/modules/ims_registrar_scscf/CMakeFiles/ims_registrar_scscf.dir/regpv.c.o.d
-o src/modules/ims_registrar_scscf/CMakeFiles/ims_registrar_scscf.dir/regpv.c.o
-c /code/src/modules/ims_registrar_scscf/regpv.c
/code/src/modules/ims_registrar_scscf/regpv.c: In function 'pv_fetch_contacts':
/code/src/modules/ims_registrar_scscf/regpv.c:477:30: error: expected
expression before '{' token
477 | c0->domain = {NULL, 0};
| ^
ninja: build stopped: subcommand failed.
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4166#discussion_r2029949231
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4166/review/2744969...@github.com>_______________________________________________
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the
sender!
