On Tue, 27 Oct 2026 23:51:58 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback cleanup > > src/jdk.hotspot.agent/macosx/native/libsaproc/libproc_impl.h line 224: > >> 222: // reads thread info using libthread_db and calls above callback for >> each thread >> 223: bool read_thread_info(struct ps_prochandle* ph, thread_info_callback >> cb); >> 224: > > Q: It seems the implementation of `read_thread_info()` and > thread_info_callback have been removed in your fix. Is there any reason why > the declarations a lines 220 and 223 are still needed? removed. > src/jdk.hotspot.agent/macosx/native/libsaproc/libproc_impl.h line 232: > >> 230: >> 231: sa_thread_info* add_thread_info(struct ps_prochandle* ph, pthread_t >> pthread_id, lwpid_t lwp_id); >> 232: // a test for ELF signature without using libelf > > Q: Is the comment about libelf at line 232 stale? It seems so. I've removed it. > src/jdk.hotspot.agent/macosx/native/libsaproc/libproc_impl.h line 264: > >> 262: >> 263: // needed for when libthread_db is compiled with TD_DEBUG defined >> 264: void ps_plog (const char *format, ...); > > Q: The same question is about `ps_plog()`: Is it still needed? It looks like this is a remnant from the freebsd support that was outside of an #ifdef. I've removed it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33524#discussion_r4395955003 PR Review Comment: https://git.openjdk.org/jdk/pull/33524#discussion_r4395956973 PR Review Comment: https://git.openjdk.org/jdk/pull/33524#discussion_r4396016936
