> I noticed under src/jdk.hotspot.agent/macosx/native/libsaproc/ we still have 
> a bunch of FreeBSD native code. You'll find it within #ifdef's like the 
> following:
> 
> #ifdef __APPLE__
> // macosx code
> #else
> // FreeBSD code
> #endif
> 
> The #else part is only needed for the FreeBSD port, which is now located 
> under src/jdk.hotspot.agent/bsd/native/libsaproc/ (in the jdk freebsd repo). 
> All of it can be deleted, and I got approval from the bsd team to do this. It 
> is a fairly large chunk of code, and removing it will make browsing the 
> macosx code simpler. No more false grep hits.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Chris Plummer has updated the pull request incrementally with one additional 
commit since the last revision:

  feedback cleanup

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/33524/files
  - new: https://git.openjdk.org/jdk/pull/33524/files/406a8dfa..b6299d22

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=33524&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=33524&range=00-01

  Stats: 20 lines in 2 files changed: 0 ins; 20 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/33524.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/33524/head:pull/33524

PR: https://git.openjdk.org/jdk/pull/33524

Reply via email to