On Tue, 13 Oct 2026 07:54:24 GMT, Stefan Karlsson <[email protected]> wrote:
>> It just looks like yet another of these cases:
>>
>>
>> bool oopDesc::is_typeArray() const { return
>> klass()->is_typeArray_klass(); }
>> bool oopDesc::is_objArray() const { return
>> klass()->is_objArray_klass(); }
>> bool oopDesc::is_refArray() const { return
>> klass()->is_refArray_klass(); }
>> bool oopDesc::is_flatArray() const { return
>> klass()->is_flatArray_klass(); }
>>
>>
>> It is an implementation detail there is `||` behind
>> `klass()->is_refined_objArray_klass()` -- maybe at some point it would
>> become a direct query.
>
> I prefer to keep it the way I suggest it here in order to keep the section
> "clean" in the sense that I described above.
>
> FWIW, I added this function during the Valhalla review and I regret bunching
> it up with the rest of the type checks.
All right, fine. There is no point in bikeshedding about this one.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33287#discussion_r4256357950
