On Mon, 12 Oct 2026 11:15:39 GMT, Aleksey Shipilev <[email protected]> wrote:
>> My thinking was the the block above should only contain the 1:1 type checks
>> and things that want to check more than that was moved out of the block.
>> This function is an oddity that checks if the type is either of two types,
>> so I relegated it from that block.
>>
>> I did the same with `is_array_with_oops`.
>>
>> You still want me to move it back?
>
> It just looks like yet another of these cases:
>
>
> bool oopDesc::is_typeArray() const { return
> klass()->is_typeArray_klass(); }
> bool oopDesc::is_objArray() const { return
> klass()->is_objArray_klass(); }
> bool oopDesc::is_refArray() const { return
> klass()->is_refArray_klass(); }
> bool oopDesc::is_flatArray() const { return
> klass()->is_flatArray_klass(); }
>
>
> It is an implementation detail there is `||` behind
> `klass()->is_refined_objArray_klass()` -- maybe at some point it would become
> a direct query.
I prefer to keep it the way I suggest it here in order to keep the section
"clean" in the sense that I described above.
FWIW, I added this function during the Valhalla review and I regret bunching it
up with the rest of the type checks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33287#discussion_r4256079521
