On Fri, 9 Oct 2026 06:36:12 GMT, Justus Garbe <[email protected]> wrote:
> But the tests run with 'vm.flagless' if that is what you meant
I agree, this is good for test stability.
What I'd like to say is that we need to make sure there are no intermittent
failures.
So, at least this test has to be run 1000's times on multiple platforms.
Changing GC's is a good idea too but I leave it to you to decide. I'm not sure
we want it to test with all GC's all the time.
>> test/hotspot/jtreg/serviceability/jvmti/SetBreakpoint/libBreakpointMetaspaceOOM.cpp
>> line 78:
>>
>>> 76: JNIEXPORT jint JNICALL
>>> 77: Java_BreakpointMetaspaceOOM_setBreakpoint(JNIEnv* env, jclass cls) {
>>> 78: return jvmti->SetBreakpoint(target, 0);
>>
>> Missed check of JVMTI error code at line 78.
>
> There is no check as the code is checked via java.
Okay then, thanks. Sorry for a false alarm.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33191#discussion_r4234854294
PR Review Comment: https://git.openjdk.org/jdk/pull/33191#discussion_r4234861391
