On Fri, 9 Oct 2026 04:55:53 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Justus Garbe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add cast for result > > test/hotspot/jtreg/serviceability/jvmti/SetBreakpoint/BreakpointMetaspaceOOM.java > line 39: > >> 37: * -XX:MaxMetaspaceSize=32m >> 38: * BreakpointMetaspaceOOM >> 39: */ > > I have a concern about this test stability on different platforms and > configurations. Forcing an OOME is always tricky and causing intermittent > failures. > We may need some explicit timeout: `@run main/othervm/native/timeout=xxx`. > Also, we may need an extensive multiple (1000's) of this test runs on > different platforms and with different VM options to prove the test is stable. I don't know how to exactly falicilitate this. I have created some tests for this with diffrent gc implementations on my computer (linux-amd64) Config (release, 1,000 runs each) Pass rc Avg Max default (G1) 1000 110 2.08 s 2.83 s -XX:+UseSerialGC 1000 110 2.58 s 6.13 s -XX:+UseParallelGC 1000 110 1.85 s 2.68 s -XX:+UseZGC 1000 110 2.26 s 4.43 s -XX:+UseShenandoahGC 1000 110 1.99 s 3.50 s -Xshare:off 1000 110 1.97 s 2.48 s -XX:+UseCompactObjectHeaders 1000 110 1.92 s 2.28 s -XX:ActiveProcessorCount=1 1000 110 1.90 s 2.79 s -XX:TieredStopAtLevel=1 1000 0 0.96 s 1.25 s The '-XX:TieredStopAtLevel=1' Also confirms that the bug most likely only shows up due to the ciStreams.cpp 'bug' But the tests run with 'vm.flagless' if that is what you meant ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33191#discussion_r4227339286
