> Please review this small fix. > > Configuring the same log file as `vm.log`, `$PWD/vm.log`, and `./vm.log` > creates separate outputs, splitting the messages across multiple files. > > **Fix:** > > When `LogConfiguration::find_output()` compares file outputs, use > `os::same_files` to check whether their paths refer to the same file. > > **Testing:** > > - Added `TestEquivalentLogFilePaths.java`. > - `gtest:LogConfiguration/server`: 21 passed, 0 failed. > - `test/hotspot/jtreg/serviceability/logging`: 7 passed, 0 failed. > - `test/hotspot/jtreg/runtime/logging`: 33 passed, 0 failed. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai).
Yunbo Zhang has updated the pull request incrementally with one additional commit since the last revision: 8392135: Unified logging creates extra log files Use virtual output name matching instead of identifying output types by name prefixes and downcasting. Add coverage for file and standard output matching. ------------- Changes: - all: https://git.openjdk.org/jdk/pull/33090/files - new: https://git.openjdk.org/jdk/pull/33090/files/73548623..b682f4d1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=33090&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=33090&range=00-01 Stats: 52 lines in 5 files changed: 39 ins; 5 del; 8 mod Patch: https://git.openjdk.org/jdk/pull/33090.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/33090/head:pull/33090 PR: https://git.openjdk.org/jdk/pull/33090
