On Mon, 28 Sep 2026 08:25:08 GMT, Yunbo Zhang <[email protected]> wrote:
> Please review this small fix. > > Configuring the same log file as `vm.log`, `$PWD/vm.log`, and `./vm.log` > creates separate outputs, splitting the messages across multiple files. > > **Fix:** > > When `LogConfiguration::find_output()` compares file outputs, use > `os::same_files` to check whether their paths refer to the same file. > > **Testing:** > > - Added `TestEquivalentLogFilePaths.java`. > - `gtest:LogConfiguration/server`: 21 passed, 0 failed. > - `test/hotspot/jtreg/serviceability/logging`: 7 passed, 0 failed. > - `test/hotspot/jtreg/runtime/logging`: 33 passed, 0 failed. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). This patch depends on `LogFileOutput`'s log name having `file=` prepended. I think that depending on this fact is a bug waiting to happen. We should try to find a way of implementing this which allows for better type safety. ------------- PR Review: https://git.openjdk.org/jdk/pull/33090#pullrequestreview-5338087253
