On Thu, 24 Sep 2026 08:44:24 GMT, Serguei Spitsyn <[email protected]> wrote:

>> This PR has fixes from @xmas92 for two bugs:
>>  - https://bugs.openjdk.org/browse/JDK-8392964: JVMTI value-object tag 
>> equality ignores inherited fields
>>  - https://bugs.openjdk.org/browse/JDK-8386824: JVMTI equal_fields compares 
>> value object floats mishandling NaNs
>> 
>> The fix accounts for inherited fields for JVMTI value-object tag equality.
>> Also, it is using bit comparison for fields of `float` and `double` types.
>> This updates provides an additional test coverage with new JVMTI test:
>>  - 
>> `test/hotspot/jtreg/serviceability/jvmti/valhalla/SetTag/ValueTagSubstitutabilityTest.java`
>>  
>>  Testing:
>>   - Checked that new test `ValueTagSubstitutabilityTest.java` is failing 
>> without this fix
>>   - Checked that new test `ValueTagSubstitutabilityTest.java` is not failing 
>> with the fix
>>   - TBD: Run mach5 tiers 1-6
>>   
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Serguei Spitsyn has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   replace bug number 8389237 with 8392964

Frederic, thank you for review!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33046#issuecomment-5823135033

Reply via email to