On Thu, 24 Sep 2026 02:29:28 GMT, Serguei Spitsyn <[email protected]> wrote:
> This PR has fixes from @xmas92 for two bugs: > - https://bugs.openjdk.org/browse/JDK-8392964: JVMTI value-object tag > equality ignores inherited fields > - https://bugs.openjdk.org/browse/JDK-8386824: JVMTI equal_fields compares > value object floats mishandling NaNs > > The fix accounts for inherited fields for JVMTI value-object tag equality. > Also, it is using bit comparison for fields of `float` and `double` types. > This updates provides an additional test coverage with new JVMTI test: > - > `test/hotspot/jtreg/serviceability/jvmti/valhalla/SetTag/ValueTagSubstitutabilityTest.java` > > Testing: > - Checked that new test `ValueTagSubstitutabilityTest.java` is failing > without this fix > - Checked that new test `ValueTagSubstitutabilityTest.java` is not failing > with the fix > - TBD: Run mach5 tiers 1-6 > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). lgtm. test/hotspot/jtreg/serviceability/jvmti/valhalla/SetTag/ValueTagSubstitutabilityTest.java line 27: > 25: * @test > 26: * @summary Regression test for JVMTIs tag map value class instance > substitutability test > 27: * @bug 8386824 8389237 Suggestion: * @bug 8386824 8392964 ------------- Marked as reviewed by aboldtch (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/33046#pullrequestreview-5299979900 PR Review Comment: https://git.openjdk.org/jdk/pull/33046#discussion_r4090077700
