On Sat, 23 May 2026 07:09:17 GMT, Yasumasa Suenaga <[email protected]> wrote:

> > the problem is the :: makes it look like a C++ name?
> 
> Yes.
> 
> > How about I change to a space. So, it looks like "StubRoutes call_stub"?
> 
> I feel it is not so different with current behavior.

My problem with the current behavior is that all the stubs are grouped together 
in one entry. In the perf map generated today, we have:

0x000071ea07a00ee0 0x0000000000004f60 StubRoutines (initialstubs)
0x000071ea07a064e0 0x0000000000000cf8 StubRoutines (continuationstubs)
0x000071ea07a31be0 0x000000000000d048 StubRoutines (finalstubs)
0x000071ea07a7dee0 0x000000000001ab08 StubRoutines (compilerstubs)

Those ranges collectively include all stub routines. `perf` is not able to 
report individual stub routines like the `call_stub`.

> I've not yet understood the problem what you reported TBH. I like to name 
> with entry field like `StubRoutines::_call_stub_entry` if we need to change, 
> but I want to ask opinions from others (and want to discuss whether we need 
> to tackle this).

I am okay with any naming as long as it distinguishes individual stubs.

Looking further, I see there is some precedent for spaces in the name. For 
example:

0x000071ea07a07260 0x0000000000000470 Shared Runtime wrong_method_blob
0x000071ea07a07760 0x0000000000000080 Shared Runtime jfr_write_checkpoint_blob
0x000071ea07a07a60 0x0000000000000070 Shared Runtime jfr_return_lease_blob

-------------

PR Comment: https://git.openjdk.org/jdk/pull/31007#issuecomment-4526241756

Reply via email to