On Thu, 30 Apr 2026 23:16:26 GMT, Benjamin Peterson <[email protected]> wrote:

> StubRoutines blobs bundle many individually-named stubs into a single 
> BufferBlob, so perf profiles previously attributed all samples inside those 
> blobs to the enclosing blob name (e.g. "StubRoutines (compiler stubs)"). Walk 
> the StubCodeDesc list and emit a line per descriptor, so perf can name the 
> actual stub.
> 
> 
> 
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

TBH I can accept current label (`StubRoutines (<label>)`) because we can 
identify the address is stub routine and its kind.
I do not deny your PR, but I do not agree with current style.

According to the change in PerfMapTest.java, we could see 
`StubRoutines::call_stub` in perf map. However we cannot identify the entry is 
stub routine or member of `StubRoutines`. `call_stub()` is a member function of 
`StubRoutines`. Thus you shouldn't concatenate with `::` at least.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/31007#issuecomment-4516527016

Reply via email to