On Fri, 15 May 2026 03:32:51 GMT, Stuart Marks <[email protected]> wrote:
>> This PR proposes to replace older `Collection.unmodifiable` wrappers with >> `Set.of()` instead. This can improve performance, reduce footprint, and >> reduce maintenance. There is also occasional use of `Map.of()` in nearby >> places where `Set.of()` was introduced. >> >> The PR also contains two optimizations in `PlatformMBeanProviderImpl` that >> remove `synchronized` from two methods. >> >> --------- >> - [X] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/TerminalBuilder.java > line 109: > >> 107: String.join(",", >> PROP_REDIRECT_PIPE_CREATION_MODE_REFLECTION, >> PROP_REDIRECT_PIPE_CREATION_MODE_NATIVE); >> 108: >> 109: public static final Set<String> DEPRECATED_PROVIDERS = >> Set.of(PROP_PROVIDER_JNA, PROP_PROVIDER_JANSI); > > Not sure if we've forked JLine or are maintaining this package in sync with > upstream JLine. Check with @lahodaj . We do sync JLine to JDK from time to time. We have changes, so changes to JLine are possible, but minimizing the changes is desirable. I.e., unless there's a strong reason to introduce JDK-specific changes like this, I would rather avoid them. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31135#discussion_r3249261845
