On Fri, 15 May 2026 03:31:29 GMT, Stuart Marks <[email protected]> wrote:

>> This PR proposes to replace older `Collection.unmodifiable` wrappers with 
>> `Set.of()` instead. This can improve performance, reduce footprint, and 
>> reduce maintenance. There is also occasional use of `Map.of()` in nearby 
>> places where `Set.of()` was introduced.
>> 
>> The PR also contains two optimizations in `PlatformMBeanProviderImpl` that 
>> remove `synchronized` from two methods.
>> 
>> ---------
>> - [X] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMCanonicalizationMethod.java
>  line 58:
> 
>> 56:             CanonicalizationMethod.EXCLUSIVE_WITH_COMMENTS,
>> 57:             DOMCanonicalXMLC14N11Method.C14N_11,
>> 58:             DOMCanonicalXMLC14N11Method.C14N_11_WITH_COMMENTS
> 
> Duplicate checking.

This is 3rd-party code. Please revert these since it makes future merges more 
difficult.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31135#discussion_r3248999317

Reply via email to