On Thu, 16 Apr 2026 12:30:07 GMT, Casper Norrbin <[email protected]> wrote:

>> I am surprised that we only ever print access flags in relation to JVMTI - I 
>> would have expected logging or crash reporting to do so. In any case I also 
>> find the `!PRODUCT` a little jarring. Given we always have JVMTI it makes no 
>> different to our binaries.
>
> After some thought, I have removed all the `#if` guards on the printers. To 
> me, these are now ordinary printing utilities belonging to either `Method`, 
> `InstanceKlass`, or `fieldDescriptor`. They are not directly tied to JVMTI, 
> so should not be guarded by it. Let me know if you agree.

That is fine with me.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30746#discussion_r3098414417

Reply via email to