On Thu, 16 Apr 2026 05:40:02 GMT, David Holmes <[email protected]> wrote:
>> Casper Norrbin has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> feedback fixes
>
> src/hotspot/share/oops/method.cpp line 2207:
>
>> 2205: st->print (" - constants: " PTR_FORMAT " ",
>> p2i(constants()));
>> 2206: constants()->print_value_on(st); st->cr();
>> 2207: st->print (" - access: 0x%x ",
>> access_flags().as_method_flags()); print_access_flags(st); st->cr();
>
> There is an existing inconsistency here in that we print the raw flags as
> "method flags" only but then we print them all. Your new code implicitly
> filters the flags by only printing the expected method flags.
`as_method_flags()` asserts that only recognized method modifiers are set, so
these are not arbitrary raw flags. Previously, the generic printer could
misinterpret overlapping bits, whereas the new method-specific printer prints
them correctly. This looks like the right behavior to me.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30746#discussion_r3093332577
