On Tue, 31 Mar 2026 16:24:57 GMT, Shiv Shah <[email protected]> wrote:

> Convert 6 non-native aod tests from main/othervm to driver mode. Added 
> classpath to target process command in AODTestRunner.java since driver mode 
> doesn't inherit classpath like othervm.
> 
> 4 native tests and 3 self-attach tests (-Djdk.attach.allowAttachSelf) stay as 
> othervm.
> 
> Testing:
> - Local macosx-aarch64: all 13 aod tests pass
> - Mach5 linux-x64-debug, windows-x64-debug: all 13 pass

The fix looks good. 
Can you please also check if tests like  VirtualMachine07 to don't set
-XX:+UsePerfData 
for debugger process. 
It is not required.

Also please check if
'@run main/othervm/native' 
can be replaced with driver?

The debugger part doesn't load native libraries and I wonder if it is possible 
to clean up these tests to use driver and run attach the native agent to the 
process.

-------------

Changes requested by lmesnik (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/30520#pullrequestreview-4039193092

Reply via email to